Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

tools/precommit/normalize_yaml_ext.py (1)

34-57: Avoid partial renames when collisions exist.

Current flow can rename some files and still fail due to collisions, leaving a mixed working tree state. Prefer validating all candidates first, then applying renames only if there are no collisions.

Proposed refactor (all-or-nothing rename pass)

 def main() -> int:
     """Rename .yml files to .yaml, exit 1 if any were renamed."""
-    renamed: list[tuple[Path, Path]] = []
+    planned: list[tuple[Path, Path]] = []
     collisions: list[tuple[Path, Path]] = []
     for f in sys.argv[1:]:
         path = Path(f)
         if path.suffix == ".yml" and path.is_file():
             new_path = path.with_suffix(".yaml")
             if new_path.exists():
                 collisions.append((path, new_path))
                 continue
-            os.rename(path, new_path)
-            renamed.append((path, new_path))
+            planned.append((path, new_path))
 
     if collisions:
         for old, new in collisions:
             print(f"ERROR: Cannot rename {old} -> {new} (destination already exists)")
         return 1
 
+    renamed: list[tuple[Path, Path]] = []
+    for old, new in planned:
+        os.rename(old, new)
+        renamed.append((old, new))
+
     if renamed:
         for old, new in renamed:
             print(f"Renamed: {old} -> {new}")

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tools/precommit/normalize_yaml_ext.py` around lines 34 - 57, The current loop
in normalize_yaml_ext.py performs renames as it iterates which can leave a
partially-renamed working tree if collisions are later detected; change the
logic in the main block that iterates over sys.argv[1:] to first collect all
candidate renames (map Path -> new_path) and detect collisions/new_path
existence using the same checks used for collisions, and only if collisions is
empty perform all os.rename operations (populating renamed afterwards); keep the
existing prints and return codes but ensure no os.rename is called until after
the preflight collision check so the rename is all-or-nothing.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes